Previously, RoutesFilter was taking an array with the filter options
(i.e., method, path, name, etc) but, as @gsteel noted, there was a
perfectly good RouteFilterOptions class available. I don't know why I
developed it, but overlooked it. This change refactors RoutesFilter to
use it instead, then goes one step further and introduces a
RouteFilterOptionsInterface so that, when no filter options are
available, an EmptyRouteFilterOptions can be supplied, hopefully making
the code easier to intuit and maintain.

Signed-off-by: Matthew Setter <[email protected]>

Signed-off-by: Matthew Setter <[email protected]>

This change stores the filter options as member variables so that
they're more readily reusable and so that it should be less likely to
make a mistake with using them at some point in the future.

Signed-off-by: Matthew Setter <[email protected]>

This change removes the class' default options, replacing them with
unions of non-empty-string|null. In doing so it's explicit that
null means the option is unset and should be ignored.

This change was motivated by @gsteel's comment
mezzio#52 (comment).
I believe that I've implemented it correctly.

Signed-off-by: Matthew Setter <[email protected]>

This is to ensure that any possible type of error is caught and handled.

Signed-off-by: Matthew Setter <[email protected]>

I'm not sure why I didn't do this originally. Perhaps I was
experimenting to learn how routing works in Mezzio more deeply.
Regardless, this change refactors ListRoutesCommand to take a
RouteCollector object instead of a ContainerInterface and from that
ContainerInterface fetching a RouteCollector.

Signed-off-by: Matthew Setter <[email protected]>

Signed-off-by: Matthew Setter <[email protected]>

This change refactors ListRoutesCommandFactory to retrieve a
ConfigLoaderInterface object from the application's DiC instead of
instantiating a RoutesFileConfigLoader object directly. The main reason
for this is to provide flexibility to the user, should they have the
need to retrieve routes in a different way than the default
implementation, which searches in config/routes.php and in any routes
registered through ConfigProvider classes.

Signed-off-by: Matthew Setter <[email protected]>

This change provides a default implementation for retrieving an
application's routes configuration. It uses the stock approach of
searching for routes in config/routes.php and any registered with the
Application object in any of the loaded ConfigProvider classes. It also
provides a simplistic example for building a custom implementation,
should it be required.

Signed-off-by: Matthew Setter <[email protected]>

This change updates the packages ConfigProvider class to register a
ConfigLoaderInterface service with the DI container provided by
DefaultRoutesConfigLoaderFactory. If a user needs to override this
implementation, they can do so as per the additional documentation in
the package's README.

Signed-off-by: Matthew Setter <[email protected]>

Co-authored-by: George Steel <[email protected]>
Signed-off-by: Matthew Setter <[email protected]>

Co-authored-by: George Steel <[email protected]>
Signed-off-by: Matthew Setter <[email protected]>

Signed-off-by: Matthew Setter <[email protected]>

Thanks to @froschdesign for pointing this out in
mezzio#58 (comment).

Signed-off-by: Matthew Setter <[email protected]>

As pointed out by @gsteel, this implementation is not required.

Signed-off-by: Matthew Setter <[email protected]>

Signed-off-by: Matthew Setter <[email protected]>

As @gsteel pointed out, this was provided in the constructor but
overwritten later, making it redundant.

Signed-off-by: Matthew Setter <[email protected]>

As per @gsteel's recommendation in
mezzio#58 (comment),
this change changes how the class is registered with the DI container.

Signed-off-by: Matthew Setter <[email protected]>

As pointed out by @gsteel, the method is not used outside of tests, so
can be removed.

Signed-off-by: Matthew Setter <[email protected]>

This change fixes a small bug in the class constructor that overrides
the work sanitising the method data provided in the call to array_map.

Signed-off-by: Matthew Setter <[email protected]>

Signed-off-by: Matthew Setter <[email protected]>

Thanks for feedback from @gsteel, this change introduces Symfony's
CommandTester in ListRoutesCommandTest to simplify the tests and to make
them (far) more maintainable.

Signed-off-by: Matthew Setter <[email protected]>

This change handles if null methods or Route::HTTP_METHOD_ANY is listed
as a method.

Signed-off-by: Matthew Setter <[email protected]>

This change uses a RouteFilterOptions object instead of an array, as the
class is much more specific than an array and was already available in
the source tree.

Signed-off-by: Matthew Setter <[email protected]>

Signed-off-by: Matthew Setter <[email protected]>